[3.5 | Switch] Separate the Audren driver into its own directory #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
halotroop2288
changed the title
halotroop2288
force-pushed
the
pr/audren-driver
branch
from
72b8f1e
to
a1156e5
Compare
|
This is a pretty disposable PR. I feel like it wouldn't make a huge difference. It did make good practice for learning how to make new directories and files in the engine, though. |
halotroop2288
force-pushed
the
pr/audren-driver
branch
from
a1156e5
to
19c197a
Compare
halotroop2288
changed the title
hokaze
reviewed
Jan 14, 2024
hokaze
approved these changes
Jan 14, 2024
There was a problem hiding this comment.
Agree with motivation behind PR, it's better organised this way even if LibNX never adds other audio drivers - and if they do, saves some work in the future
Reviewed all changes, looks good to me!
(I have a longer comment on audio_driver_audren.cpp about moving some the includes to audio_driver_audren.h - but that's purely a matter of opinion on conventions and best practices, it's not a real issue of note nor something I care about enough to insist upon)
halotroop2288
force-pushed
the
pr/audren-driver
branch
from
19c197a
to
541abf7
Compare
Separated the Switch audio driver into its own directory, behind a preprocessor flag. There may be other audio drivers provided by the LibNX in the future.
halotroop2288
force-pushed
the
pr/audren-driver
branch
from
541abf7
to
0bcc1d0
Compare
hokaze
approved these changes
Jan 22, 2024
halotroop2288
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There may be other audio drivers provided by the LibNX in the future.