Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add get and set functions for joypad motion sensors #4

Merged
merged 1 commit into from
Jan 14, 2024
Merged

Add get and set functions for joypad motion sensors #4

merged 1 commit into from
Jan 14, 2024

Conversation

halotroop2288
Copy link
Member

For all existing platforms, these do exactly the same thing as the device motion sensor methods.

But these will be useful for platforms that expose each controller's motion sensor data.

@halotroop2288 halotroop2288 added documentation Improvements or additions to documentation enhancement New feature or request labels Jan 13, 2024
@halotroop2288 halotroop2288 self-assigned this Jan 13, 2024
@halotroop2288
Add get and set functions for joy motion sensors
3e8093b 
For all existing platforms, these do exactly the same thing as the device motion sensor methods.

But these will be useful for platforms that expose each controller's motion sensor data.
hokaze
hokaze approved these changes Jan 14, 2024
View reviewed changes
Copy link

@hokaze hokaze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, and discussed in Discord call

c08oprkiua
c08oprkiua approved these changes Jan 14, 2024
View reviewed changes
Copy link
Member

@c08oprkiua c08oprkiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd maybe add something in the documentation about what "gravity" of a controller means, but eh. Looks good!

@halotroop2288
Copy link
Member Author

I'd maybe add something in the documentation about what "gravity" of a controller means, but eh.

I blame Godot proper for that blunder.

@halotroop2288 halotroop2288 merged commit 57f8674 into Homebrodot:main/3.5 Jan 14, 2024
15 checks passed
@halotroop2288 halotroop2288 deleted the pr/joy-motion branch January 14, 2024 05:03
@halotroop2288 halotroop2288 removed the request for review from technicaljicama January 14, 2024 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c08oprkiua c08oprkiua c08oprkiua approved these changes

@hokaze hokaze hokaze approved these changes

Assignees

@halotroop2288 halotroop2288

Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
Homebrew Ports
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@halotroop2288 @hokaze @c08oprkiua