Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added COS Blog API and removed old Nurturing API #58

Open
wants to merge 28 commits into
base: master
Choose a base branch
from
Open

Added COS Blog API and removed old Nurturing API #58

wants to merge 28 commits into from

Conversation

drcraig
Copy link

@drcraig drcraig commented Jan 24, 2014

Tried to follow the conventions in the CMS Blog API.

The Nurturing API failed its tests because the endpoints appeared to no longer exist.

description="A python wrapper around HubSpot's APIs",
long_description=open('README.md').read(),
author='HubSpot Dev Team',
author_email='[email protected]',
url='https://github.com/HubSpot/hapipy',
download_url='https://github.com/HubSpot/hapipy/tarball/v2.10.3',
url='https://github.com/CurataEng/hapipy',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean to check this in?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did, it seemed to affect how pip installed my fork. I'm not terribly
knowledgeable about Python packaging, but I assume that these should be
reverted (or really, the download_url should be updated to the new tag)
when you merge back into the true repo.

On Fri, Jan 24, 2014 at 10:55 AM, jessbrandi [email protected]:

In setup.py:

 description="A python wrapper around HubSpot's APIs",
 long_description=open('README.md').read(),
 author='HubSpot Dev Team',
 author_email='[email protected]',

Did you mean to check this in?


Reply to this email directly or view it on GitHubhttps://github.com//pull/58/files#r9152481
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants