Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: change remote package path to relative path inside import_module() in starlark packages #182

Merged
merged 1 commit into from
Sep 28, 2023
Merged

refactor: change remote package path to relative path inside import_module() in starlark packages #182

merged 1 commit into from
Sep 28, 2023

Conversation

Mr-Nobody21
Copy link
Contributor

Description:

changed remote package path to relative path inside import_module in starlark packages

Commit Message

refactor: change remote package path to relative path

see the guidelines for commit messages.

Changelog Entry

version: <log entry>

Checklist:

  • I have performed a self-review of my own code
  • I have documented my code in accordance with the documentation guidelines
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have run the unit tests
  • I only have one commit (if not, squash them into one commit).
  • I have a descriptive commit message that adheres to the commit message guidelines

Please review the CONTRIBUTING.md file for detailed contributing guidelines.

@Mr-Nobody21 Mr-Nobody21 changed the title refactor: change remote package path to relative path refactor: change remote package path to relative path inside import_module() in starlark packages Sep 28, 2023
@shreyasbhat0 shreyasbhat0 merged commit e90f49d into main Sep 28, 2023
1 of 2 checks passed
@shreyasbhat0 shreyasbhat0 deleted the DIVE-150-Refactor-for-the-upcoming-change-in-kurtosis-for-DIVE-cli branch September 28, 2023 07:26
@Mr-Nobody21 Mr-Nobody21 mentioned this pull request Sep 28, 2023
Closed
shreyasbhat0 pushed a commit that referenced this pull request Jan 24, 2024
@Mr-Nobody21 @abhiyana
refactor: change remote package path to relative path inside import_m…
ec327db 
…odule() in starlark packages (#182)

Co-authored-by: abhiyana <[email protected]>
@sindhu0820 sindhu0820 added the bug Something isn't working label Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shreyasbhat0 shreyasbhat0 shreyasbhat0 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Mr-Nobody21 @shreyasbhat0 @sindhu0820 @abhiyana