fix stale onMessage prop (#251)

HumeAI · Aug 27, 2024 · 6510d05 · 6510d05
1 parent 6539dbe
commit 6510d05
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 7 deletions.
diff --git a/packages/embed-react/package.json b/packages/embed-react/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@humeai/voice-embed-react",
-  "version": "0.1.11",
+  "version": "0.1.12-beta.1",
   "description": "",
   "main": "./dist/index.js",
   "module": "./dist/index.mjs",

diff --git a/packages/embed/package.json b/packages/embed/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@humeai/voice-embed",
-  "version": "0.1.11",
+  "version": "0.1.12-beta.1",
   "description": "",
   "main": "./dist/index.js",
   "module": "./dist/index.mjs",

diff --git a/packages/react/package.json b/packages/react/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@humeai/voice-react",
-  "version": "0.1.11",
+  "version": "0.1.12-beta.1",
   "description": "",
   "main": "./dist/index.js",
   "module": "./dist/index.mjs",

diff --git a/packages/react/src/lib/VoiceProvider.tsx b/packages/react/src/lib/VoiceProvider.tsx
@@ -86,7 +86,9 @@ const VoiceContext = createContext<VoiceContextType | null>(null);
 
 export type VoiceProviderProps = PropsWithChildren<SocketConfig> & {
   sessionSettings?: Hume.empathicVoice.SessionSettings;
-  onMessage?: (message: Hume.empathicVoice.SubscribeEvent) => void;
+  onMessage?: (
+    message: Hume.empathicVoice.JsonMessage & { receivedAt: Date },
+  ) => void;
   onError?: (err: VoiceError) => void;
   onOpen?: () => void;
   onClose?: Hume.empathicVoice.chat.ChatSocket.EventHandlers['close'];
@@ -141,10 +143,13 @@ export const VoiceProvider: FC<VoiceProviderProps> = ({
   const onClose = useRef(props.onClose ?? noop);
   onClose.current = props.onClose ?? noop;
 
+  const onMessage = useRef(props.onMessage ?? noop);
+  onMessage.current = props.onMessage ?? noop;
+
   const toolStatus = useToolStatus();
 
   const messageStore = useMessages({
-    sendMessageToParent: props.onMessage,
+    sendMessageToParent: onMessage.current,
     messageHistoryLimit,
   });
 

diff --git a/packages/react/src/lib/useMessages.ts b/packages/react/src/lib/useMessages.ts
@@ -101,9 +101,8 @@ export const useMessages = ({
         default:
           break;
       }
-      // eslint-disable-next-line react-hooks/exhaustive-deps
     },
-    [],
+    [messageHistoryLimit, sendMessageToParent],
   );
 
   const onPlayAudio = useCallback(