Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

187 - Delete a picture from a document #210

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

187 - Delete a picture from a document #210

wants to merge 2 commits into from

Conversation

nitram35
Copy link
Contributor

We Martin GANDON, Fabien PETIT, Raphaël WEIS, Barnabé PETIT, Louis DUHALBERRUER, hereby grant to Hyperglosae maintainers the right to publish our contribution under the terms of any licenses the Free Software Foundation classifies as Free Software Licenses.

Closes #187

@raphaelweis
Copy link
Contributor

raphaelweis commented Jun 18, 2024

The commits on feature-153 shouldn't change anymore. Until they're merged, you should rebase on top of the feature-153 branch to integrate the latest commits from the upload an image feature. This will prevent somme conflicts in the future when feature-153 gets merged into main. @nitram35

There is also a weird FEATURE commit from Louis in the PR, did you mean to include it ?

@benel
Copy link
Member

benel commented Jun 19, 2024

The commits on feature-153...

@raphaelweis Who is this message for?

@raphaelweis
Copy link
Contributor

The commits on feature-153...

@raphaelweis Who is this message for?

The message was for @nitram35 and @petitfa1 so that they can fix the commit history for this PR and earn the corresponding badge.

@nitram35 nitram35 force-pushed the feature-187 branch 2 times, most recently from 3b254cd to 5f6c867 Compare June 19, 2024 14:59
@nitram35
Copy link
Contributor Author

Thanks to @raphaelweis the git expert who helped me to rewrite the contribution history according to his message

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delete a picture from a document
6 participants