Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TEST : Browse items while moving in a physical space (see #369) #541

Draft
wants to merge 1 commit into
base: v7
Choose a base branch
from

Conversation

qhainos
Copy link
Contributor

@qhainos qhainos commented Jun 24, 2021

Content

Implements the Ruby tests in features/step_definitions/event.rb to allow the Capybara tests (see #522 ) to work.


Checklist

Please check that your pull request is correct:

  • Each commit:
    • corresponds to a contribution that should be notified to users,
    • does not generate new errors or warnings at compile or test time,
    • must be attributed to its real authors (with correct GitHub IDs and correct syntax for multiple authors).
  • The title of a commit should:
    • begin with a contribution type
      • FEATURE for a behaviour allowing a user to do something new,
      • FIX for a behaviour which has been changed in order to meet user’s expectations,
      • SCENARIO for examples showing a given behaviour,
      • TEST when it concerns an acceptance test of a given behaviour,
      • PROCESS for a change in the way the software is built, tested, deployed,
      • DOC when it concerns only internal documentation (however it is better to combine it with the contribution that required this documentation change),
    • be followed by a colon (:) with one space after and no space before,
    • be followed by a title (written in English) as short, as user-centered and as explicit as possible
      • If it is a feature, the title must be the user action (beginning with a verb, and please not manage),
      • If it is a fix, the title must describe the intended behavior (with should).
    • ends with a reference to the corresponding ticket with the following syntax:
      • (closes #xx) if xx is a feature ticket (and the commit is a complete implementation),
      • (fixes #xx) if xx is a fix ticket (and the commit is a complete fix),
      • (see #xx) otherwise,
  • Each committed line is:
    • useful (it would not work if removed)
      • if it is a comment line, its information could not be conveyed by better variables and function naming, better code structuring, or better commit message,
    • related to this very contribution (feature, fix...),
    • in English (with the exception of Gherkin scenarios in French and resulting steps),
    • without any typo in variable, class or function names,
    • correctly indented (spaces rather than tabs, same number of characters as in the rest of the file).

@benel
Copy link
Member

benel commented Jun 24, 2021

Merci @qhainos et @Danvorst.

Je n'ai pas encore regardé le code de votre test (je le testerai d'abord sur la fonctionnalité).

Par contre, à propos de l'historique :

  • le préfixe doit être TEST tout simplement,
  • le (see #369) c'est dans le commit qu'il faut le mettre (cela va créer un lien bidirectionnel bien pratique entre le commit et le ticket),
  • le Co-authored-by: Benoit Savornin <[email protected]> c'est dans le commit qu'il faut le mettre (cela va permettre d'ajouter son avatar à celui du committer). [Note : il est donc inutile de le faire pour le committer.]

@qhainos qhainos force-pushed the hainos/369_acceptance_tests branch from 9c98873 to 3ed44f7 Compare June 25, 2021 09:50
@benel
Copy link
Member

benel commented Jun 26, 2021

Bonsoir @qhainos et @Danvorst.

Avez-vous essayé les tests avec l'implémentation ?

@benel benel marked this pull request as draft April 6, 2022 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants