Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to add the References to the ToC #228

Merged
merged 1 commit into from
Dec 20, 2023

Conversation

jwbos
Copy link
Collaborator

@jwbos jwbos commented Dec 20, 2023

No description provided.

@jwbos jwbos requested a review from kmccurley December 20, 2023 13:52
Copy link
Member

@kmccurley kmccurley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified that this generates the correct bookmarks, and I'm satisfied with it. I'm wondering why we don't just use \RequirePackage{tocbibind}. That package does more, like adding unnumbered sections to the bookmarks. By the way, I have a test for this now.

@jwbos jwbos merged commit c266767 into main Dec 20, 2023
1 check failed
@jwbos
Copy link
Collaborator Author

jwbos commented Dec 20, 2023

I verified that this generates the correct bookmarks, and I'm satisfied with it. I'm wondering why we don't just use \RequirePackage{tocbibind}. That package does more, like adding unnumbered sections to the bookmarks. By the way, I have a test for this now.

Great, not sure if we need a dependency on yet another package. We could do this if we want to add unnumbered sections to the bookmarks in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants