Fix encoding_for_model to return nil for unknown encoding #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IAPark
requested changes
Mar 25, 2024
lib/tiktoken_ruby.rb
Outdated
| end | ||
| encoding && get_encoding(encoding) |
There was a problem hiding this comment.
I'd prefer
if encoding
get_encoding(encoding)
else
nil
endbut only weakly
There was a problem hiding this comment.
Thanks for taking care of that. I didn't mean to leave this hanging, but it's a pretty simple change.
IAPark
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses issue #28.
Currently, when you pass an unrecognized model name to
Tiktoken.encoding_for_model, instead of returning nil it returns an unexpected Hash, making it more difficult to detect whether the encoding is available. This seems to have been introduced by 0c1a45bAdded a simple spec to confirm.