Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: Lagrangian MC particle pusher #345

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Conversation

jmstone
Copy link
Collaborator

@jmstone jmstone commented Aug 1, 2024

In GitLab by @gnwong on Mar 22, 2024, 24:20

This merge request implements the Lagrangian "Monte Carlo" particle pusher described in Genel+ 2013 (MNRAS.435.1426G).

Changes:

  • Implementation of ParticlesPusher::lagrangian_mc
  • Addition of new ParticleType::lagrangian_mc

As originally opened, this MR should not be approved until design decisions regarding (at least) the following are addressed:

  • IPX, ... vs. IVX, ...
  • Should restrictions be introduced/enforced for which pushers can be used with which particle types?
  • Should the captures for the lambda in the pusher go outside of a switch statement or within an if block?
  • What are best practices regarding creation of the Kokkos::Random_XorShift64_Pool?
  • Is the default behavior for finding flx1(k,j,i) correct when not three_d?
  • What are best practices for auto &flx3_ when not three_d?
  • Are the right fluxes being used? Are the scalings with dx# and dt correct?
  • Closely related to the above: what is the right way to handle the time ordering of the update and the time integrator?
  • This code has not been tested.
  • The particles may or may not be broken in AMR.

@jmstone
Copy link
Collaborator Author

jmstone commented Aug 1, 2024

In GitLab by @gnwong on Apr 2, 2024, 01:52

added 1 commit

  • b8a35ef - use corrected full-step fluxes

Compare with previous version

@jmstone
Copy link
Collaborator Author

jmstone commented Aug 1, 2024

In GitLab by @gnwong on Jul 9, 2024, 03:21

added 4 commits

  • b8a35ef...9971d5a - 2 commits from branch master
  • 0ea3792 - attempt to merge branch 'particles_smr' into feature/lagrangian_mc
  • f01ab9a - update with fixes of mesh refined code for particle indexing. still need to be...

Compare with previous version

@jmstone
Copy link
Collaborator Author

jmstone commented Aug 1, 2024

In GitLab by @gnwong on Jul 31, 2024, 11:30

added 1 commit

Compare with previous version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants