Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import BBH initial data from SpECTRE #578

Merged
merged 2 commits into from
Sep 3, 2024

Conversation

nilsvu
Copy link
Contributor

@nilsvu nilsvu commented Aug 15, 2024

Add support for importing BBH initial data generated by the SXS collaboration's open-source SpECTRE code.

@HengruiPrinceton and I have been evolving this data with AthenaK, with the idea to evolve high-mass-ratio and high-spin BBHs on GPUs. The SpECTRE code can generate non-conformally-flat, high-spin BBH initial data for this. It's excision data, so it is extrapolated into the excisions and then collapses into moving puncture gauge.

I'm working on a tutorial for generating and importing SpECTRE initial data, which I will link here once it's merged upstream in https://github.com/sxs-collaboration/spectre.

This is my first PR to AthenaK, so let me know if I missed something :)

@HengruiZhu99
Copy link
Collaborator

Hi @jmstone, this branch is ready to be merged.

@jmstone jmstone merged commit fa0e6a5 into IAS-Astrophysics:main Sep 3, 2024
4 checks passed
@nilsvu nilsvu deleted the import_spectre_id branch September 3, 2024 17:12
dradice pushed a commit that referenced this pull request Sep 9, 2024
* Import BBH initial data from SpECTRE

* fix linting

---------

Co-authored-by: Hengrui Zhu <[email protected]>
jmstone pushed a commit that referenced this pull request Sep 16, 2024
* hotfixing z4c amr and remove most warnings at compile time

* linting

* draft to factor out Tmunu if vacuum

* fix flag, but segfault

* set alias for tmunu

* lint

* Import BBH initial data from SpECTRE (#578)

* Import BBH initial data from SpECTRE

* fix linting

---------

Co-authored-by: Hengrui Zhu <[email protected]>

* Redesign of the Z4c AMR to support BHNS and NSNS binaries

* PunctureTracker has been replaced by the more general CompactObjectTracker
* The user can now specify the minimum resolution at different radii
* The L2, LInf refinement criteria have been simplified and generalized
* CompactObjectTracker data and Z4c::last_output_time are added to the
  restart files
* All MPI_Reduces in WaveExtr have been consolidated into one

* Output the elapsed time to screen when running

* Remove old TODO

* Revert Kokkos to version 4.1

* Fix typo in Z4c_AMR

* bug fix

---------

Co-authored-by: Hengrui Zhu <[email protected]>
Co-authored-by: Nils Vu <[email protected]>
Co-authored-by: David Radice <[email protected]>
Co-authored-by: ZhuHengrui <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants