horizon find and cartesian grid dump

[HengruiZhu99]

dumping data on Cartesian grid with application to horizon finder

[dradice]

I am not sure why we would want to convert the tracker list to a list of pointers, which is what is being done here.

[dradice]

It would be better not to make pos public and instead use GetPos() to get the compact object position

[HengruiZhu99]

It would be better not to make pos public and instead use GetPos() to get the compact object position

Done!

[dradice]

• I do not understand the logic for why parfilename is given as a parameter to the function and then overwritten. Also, there is no guarantee that parfilename will really be 100 characters wide, so it would be safer to pass a char const * if you want to have the filename as input.
• You should not use sprintf, use snprintf instead (or use C++ strings)

[HengruiZhu99]

Fixed! Originally I wanted to run the ahfinder as soon as the file is dumped, so I'm saving the name of the parfile. But I then decided against that.

[dradice]

Why are you using make_unique instead of emplace_back? I think it is better to have a list of objects, rather than a list of pointers

[HengruiZhu99]

I'm using the smart pointer to avoid complications of memory management using std::vector

[HengruiZhu99]

I am not sure why we would want to convert the tracker list to a list of pointers, which is what is being done here.

I mainly want to use the std::vector because of the easiness of accessing the elements. For the std::list I need an iterator making it more lengthy to pass the position of puncture into the horizon dump object.