Inline icons #27
Merged
Inline icons #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tillywoodfield
force-pushed
the
inline-icons
branch
from
d08d4f9 to
cc9bde6
Compare
tillywoodfield
force-pushed
the
social-links
branch
from
7e65373 to
7bdf7b7
Compare
tillywoodfield
force-pushed
the
inline-icons
branch
from
cc9bde6 to
301bda9
Compare
tillywoodfield
force-pushed
the
social-links
branch
from
7bdf7b7 to
acdc38d
Compare
tillywoodfield
force-pushed
the
inline-icons
branch
from
301bda9 to
dd8c404
Compare
Consuming apps no longer have to serve the image files
tillywoodfield
force-pushed
the
inline-icons
branch
from
dd8c404 to
cd247bf
Compare
simon-20
approved these changes
Dec 10, 2024
|
🎉 This PR is included in version 3.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes in #23 use vite to inline SVGs into the compiled CSS, so that consuming apps don't have to serve the SVGs separately. However, this doesn't work for the Sphinx theme because it depends on the
.scssfiles directly. It does this because it uses Sass to extend the design system classes to apply to the ones which Sphinx generates automatically. For example, applying the.iati-calloutclass styles to the Sphinx.admonitionclass.This PR does two things to make that work:
.scsscode so that they are available when installing via NPM