-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial working version of theme #5
Conversation
This is looking great, @tillywoodfield ! Things to fix before merging
Things to fix promptly after merging
|
@tillywoodfield Also - just talked to @mollieodsc and she's asking whether it's the right font? It might be the logo font, but not the content font. |
@tillywoodfield @robredpath thanks Rob! Tilly, this is great! I think the the font for headings on the sphinx theme is avenir, and it looks like the iatistandard.org uses pragmatica. But really nice to see this coming together, thanks for your work on it! |
@robredpath thank you, I'm working through your feedback points currently, and thanks @mollieodsc for pointing out the fonts, I had copied the ones from the Validator, but will update to the proper ones :) |
Once languages are set up properly on read the docs, this should appear in the read the docs menu (see this example). But, we may want a more prominent language switcher too. |
@robredpath I've made updates for most of the comments, you might need to do a cache clear/hard reload on the RTD PR build to see it all properly. The main outstanding item is collapsing the menu and providing a burger icon on small screens as I need to add some javascript for that, but for now I've placed it at the top of the page instead of disappearing. |
Thanks @tillywoodfield - this is looking great. I don't think that the menu-burger has to block merging now as moving the menu to the top does mean that someone can access the content. |
Just writing up a couple of points from discussion with @tillywoodfield this morning:
...and I think that's it for now! EDIT: I remembered another - let's randomise the admonition colours (avoiding red and orange for warnings/errors) so that we're not using RAG badly |
@robredpath I've removed the HOME link from the header. I tried to add a home link to the left contents table, but found that if we hard-code it in Sphinx doesn't add the |
@robredpath I had a play around with the admonition colours but I think that making them random might end up more confusing, so I've set them all to be blue for now, but happy to change it, see what you think |
Thanks @tillywoodfield - that makes sense. I'd still like a couple of different colours, though - can we maybe have Attention be purple, Caution be yellow and Note be green? Leaving the rest blue makes sense - that's a good point about the randomness. That's fine about the home link for now; we can figure that out later. |
@robredpath yep no problem, I've updated those colours |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work - I'm happy!
Depends on IATI/design-system#6