Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show error when file upload fails #635

Merged
merged 1 commit into from
Jul 9, 2024
Merged

Show error when file upload fails #635

merged 1 commit into from
Jul 9, 2024

Conversation

tillywoodfield
Copy link
Contributor

@tillywoodfield tillywoodfield commented Jun 19, 2024 •
edited
Loading

See #558

@tillywoodfield tillywoodfield mentioned this pull request Jun 19, 2024
Open
@tillywoodfield tillywoodfield requested a review from simon-20 June 25, 2024 11:34
simon-20
simon-20 approved these changes Jun 25, 2024
View reviewed changes
Copy link
Contributor

@simon-20 simon-20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small query about that console.error call.

src/components/LocalFilesValidator.vue Show resolved Hide resolved
@tillywoodfield tillywoodfield force-pushed the upload_error_bug branch 3 times, most recently from b07d2ff to 7fa8162 Compare July 9, 2024 06:32
@tillywoodfield tillywoodfield merged commit a47481b into develop Jul 9, 2024
2 checks passed
@tillywoodfield tillywoodfield deleted the upload_error_bug branch July 9, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simon-20 simon-20 simon-20 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tillywoodfield @simon-20