-
Notifications
You must be signed in to change notification settings - Fork 48
Modifying title and architecture diagram - aligning with our Journey "Code" site #5
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like to review these changes again. Please schedule a meeting to talk about these changes.
@@ -1,4 +1,4 @@ | |||
# air-traffic-control | |||
# Correlating Flight and Weather Data in Augmented Reality | |||
[![Build Status](https://travis-ci.org/IBM/air-traffic-control.svg?branch=master)](https://travis-ci.org/IBM/air-traffic-control) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This project is more than just correlating flight and weather data in Augmented Reality. It has a Raspberry Pi powered Ground Station that uses a Software Defined Radio to receive ADS-B messages, decode the ADS-B messages to retrieve flight information, and then publishes MQTT messages with flight information in the JSON payload over to IoT Platform. In effect, we are diluting the most important aspect of this project if we say that it is just Correlating Flight and Weather Data in Augmented Reality
. Please contact me if you have any questions about this.
@@ -16,7 +16,8 @@ IoT Platform service will also be able to serve the flight information to all th | |||
## Architecture | |||
Following figure shows the high-level architecture of a Cloud-based Air Traffic Control that relies on cheap Ground Stations to track flights | |||
|
|||
![alt tag](https://github.com/IBM/air-traffic-control/blob/master/assets/architecture_diagram_v2.png) | |||
![alt tag](https://github.com/ljbennett62/air-traffic-control/blob/master/assets/arch-iot-airtrafficcontrol-1024x878.png) | |||
![alt tag](https://github.com/ljbennett62/air-traffic-control/blob/master/assets/AR-steps.png) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The explanation of steps in AR-steps.png
is way off. It would be better to have a meeting to talk about these steps so that they can be accurate.
@@ -16,7 +16,8 @@ IoT Platform service will also be able to serve the flight information to all th | |||
## Architecture | |||
Following figure shows the high-level architecture of a Cloud-based Air Traffic Control that relies on cheap Ground Stations to track flights | |||
|
|||
![alt tag](https://github.com/IBM/air-traffic-control/blob/master/assets/architecture_diagram_v2.png) | |||
![alt tag](https://github.com/ljbennett62/air-traffic-control/blob/master/assets/arch-iot-airtrafficcontrol-1024x878.png) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The arrows on some of the lines in the diagram need to be switched. Once again, it would be better to schedule a meeting to talk about these things.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok - will schedule.
Changed the title and the architecture diagram so it aligns with what is on our Code site.