Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Eric Avdey <[email protected]>
Signed-off-by: Rich Ellis <[email protected]>
  • Loading branch information
ricellis and eiri authored Jan 26, 2024
1 parent 8c7baba commit 48b3f79
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions examples/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ checked out out version.

The scripts expect AWS ini files:
* shared credentials file `~/.aws/credentials` or target file from `AWS_SHARED_CREDENTIALS_FILE` environment variable
* shared configuration file `~/.aws/config` or taret file from `AWS_CONFIG_FILE` environment variable
* shared configuration file `~/.aws/config` or target file from `AWS_CONFIG_FILE` environment variable

###### IBM COS

Expand Down Expand Up @@ -86,6 +86,6 @@ use the `DEBUG` environment variable with label `s3-backup` e.g.

#### Known issues

The S3 SDK does not apepar to apply back-pressure to a Node `stream.Readable`. As such in environemnts
where the upload speed to S3 is signficantly slower than either the speed of downloading from the database
The S3 SDK does not appear to apply back-pressure to a Node `stream.Readable`. As such in environments
where the upload speed to S3 is significantly slower than either the speed of downloading from the database
or reading the backup file then the scripts may fail.

0 comments on commit 48b3f79

Please sign in to comment.