feat: add --no-version-check cmdline option
#139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnwe
force-pushed
the
no-version-check
branch
3 times, most recently
from
73ecf52 to
3d242ad
Compare
Skip the remote version check (to s3) if the user passes `--no-version-check` as a cmdline option. Fixes IBM#42 Signed-off-by: Dominic Evans <[email protected]>
Python 3.7 is no longer maintained and various deps (e.g., numpy) contain CVEs at the last version supported on 3.7. Bump the minimum to 3.8 to avoid this CVE being detected in the build. Signed-off-by: Dominic Evans <[email protected]>
dnwe
force-pushed
the
no-version-check
branch
from
3d242ad to
9ba64a9
Compare
|
Hi @dnwe, thank you for your contribution! Looks great. I did some manual testing with this Python script to verify that the new option works: import detect_secrets.main
import detect_secrets.pre_commit_hook
# Scan subcommand with new flag
# detect_secrets.main.main(["--no-version-check", "scan", "--update", ".secrets.baseline"])
# detect_secrets.main.main(["--no-version-check", "scan"])
# Audit subcommand with new flag
# detect_secrets.main.main(["--no-version-check", "audit", ".secrets.baseline"])
# detect_secrets.main.main(["--no-version-check", "audit", "--report", ".secrets.baseline"])
# Pre-commit hook with new flag
# detect_secrets.pre_commit_hook.main(["--no-version-check"]) |
victoria-miltcheva
approved these changes
Dec 1, 2023
victoria-miltcheva
suggested changes
Dec 1, 2023
There was a problem hiding this comment.
Before I merge, could you bump the version here? The 61 just needs to be changed to 62
Signed-off-by: Dominic Evans <[email protected]>
dnwe
force-pushed
the
no-version-check
branch
from
7288e8b to
3dabb50
Compare
victoria-miltcheva
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skip the remote version check (to s3) if the user passes
--no-version-checkas a cmdline option.Fixes #42