Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(test): modernise and skip db2 tests on arm64 #151

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

dnwe
Copy link

@dnwe dnwe commented May 15, 2024

  • add pytest skip to ibm_db2 tests on arm64 and mark module as x86_64
    only in requirements-dev.txt
  • move 'testing' helpers module under tests/ and load via conftest for
    better compatibility when testing installed module / under venv

Additionally

  • fix flake8 warnings around isinstance use
  • add max-line-length to setup.cfg to avoid E501 flagging existing code
    (and 100 is the standard default in most Python modules due to black/ruff)
  • fix existing pre-commit findings on master that were causing Travis to fail
  • additionally run autoupdate on pre-commit file to bring it up-to-date

dnwe added 2 commits May 15, 2024 11:41
- add pytest skip to ibm_db2 tests on arm64 and mark module as x86_64
  only in requirements-dev.txt
- move 'testing' helpers module under tests/ and load via conftest for
  better compatibility when testing installed module / under venv

Signed-off-by: Dominic Evans <[email protected]>
Also add max-line-length to setup.cfg to avoid E501 flagging existing code
(and 100 is the standard default in most Python modules due to black/ruff)

Signed-off-by: Dominic Evans <[email protected]>
@dnwe dnwe force-pushed the housekeeping branch 2 times, most recently from c34e3bf to 1c8fc1d Compare May 15, 2024 12:48
dnwe added 2 commits May 15, 2024 14:12
This appears to be run in Travis and is failing because these fixes were
required, so apply them to get Travis passing again.

Signed-off-by: Dominic Evans <[email protected]>
Signed-off-by: Dominic Evans <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant