-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
INS-48042: Rename Record to UCRecord #608
Open
chirag-ibm
wants to merge
68
commits into
IBM:main
Choose a base branch
from
chirag-ibm:INS-48042-rename-record-to-ucrecord
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
INS-48042: Rename Record to UCRecord #608
chirag-ibm
wants to merge
68
commits into
IBM:main
from
chirag-ibm:INS-48042-rename-record-to-ucrecord
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chirag Soni <[email protected]>
Signed-off-by: Chirag Soni <[email protected]>
Signed-off-by: Chirag Soni <[email protected]>
Signed-off-by: Chirag Soni <[email protected]>
Signed-off-by: Chirag Soni <[email protected]>
Signed-off-by: Chirag Soni <[email protected]>
Signed-off-by: Chirag Soni <[email protected]>
Signed-off-by: Chirag Soni <[email protected]>
Signed-off-by: Chirag Soni <[email protected]>
Signed-off-by: Chirag Soni <[email protected]>
Signed-off-by: Chirag Soni <[email protected]>
Signed-off-by: Chirag Soni <[email protected]>
Signed-off-by: Chirag Soni <[email protected]>
Signed-off-by: Chirag Soni <[email protected]>
Signed-off-by: Chirag Soni <[email protected]>
Signed-off-by: Chirag Soni <[email protected]>
Signed-off-by: Chirag Soni <[email protected]>
Signed-off-by: Chirag Soni <[email protected]>
Signed-off-by: Chirag Soni <[email protected]>
Signed-off-by: Chirag Soni <[email protected]>
Signed-off-by: Chirag Soni <[email protected]>
Signed-off-by: Chirag Soni <[email protected]>
Signed-off-by: Chirag Soni <[email protected]>
Signed-off-by: Chirag Soni <[email protected]>
Signed-off-by: Chirag Soni <[email protected]>
Signed-off-by: Chirag Soni <[email protected]>
Signed-off-by: Chirag Soni <[email protected]>
Signed-off-by: Chirag Soni <[email protected]>
Signed-off-by: Chirag Soni <[email protected]>
Signed-off-by: Chirag Soni <[email protected]>
Signed-off-by: Chirag Soni <[email protected]>
Signed-off-by: Chirag Soni <[email protected]>
Signed-off-by: Chirag Soni <[email protected]>
Signed-off-by: Chirag Soni <[email protected]>
Signed-off-by: Chirag Soni <[email protected]>
Signed-off-by: Chirag Soni <[email protected]>
Signed-off-by: Chirag Soni <[email protected]>
Signed-off-by: Chirag Soni <[email protected]>
Signed-off-by: Chirag Soni <[email protected]>
Signed-off-by: Chirag Soni <[email protected]>
Signed-off-by: Chirag Soni <[email protected]>
Signed-off-by: Chirag Soni <[email protected]>
Signed-off-by: Chirag Soni <[email protected]>
Signed-off-by: Chirag Soni <[email protected]>
Signed-off-by: Chirag Soni <[email protected]>
Signed-off-by: Chirag Soni <[email protected]>
chirag-ibm
requested review from
devanshah2,
Tal-Daniel,
ofer-haim,
natalygmkibm,
apurva-birajdar,
itai-g-weather-com,
RefaelAdi,
PratikshaSonawane,
hadarkorny,
doryo and
rasikashete3
as code owners
October 21, 2024 15:50
natalygmkibm
approved these changes
Oct 22, 2024
natalygmkibm
approved these changes
Oct 22, 2024
import java.util.regex.Matcher; | ||
import java.util.regex.Pattern; | ||
import com.google.gson.Gson; | ||
import com.google.gson.JsonArray; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all this was obsolete? I assume compilation passed, right?
hadarkorny
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.