Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflict cases when aria-autocomplete and autocomplete are used together #2052

Closed
shunguoy opened this issue Sep 18, 2024 · 4 comments
Closed
Assignees
Labels
Carbon Carbon related issue T63

Comments

@shunguoy
Copy link
Contributor

shunguoy commented Sep 18, 2024

From user: If we remove autocomplete=off the browser will no longer be instructed to not add it's own autocomplete dropdown/listbox, which would harm UX of the existing listbox provided by our component.
If we remove aria-autocomplete and keep autocomplete="off" assistive tech won't be provided the inline/list/both hint.

There are two aspects to this. One is that when conflicting or overlapping native and aria attributes exist, a user agent may choose to ignore the aria attribute. However, in this specific case, it works fine with the autocomplete=off and aria-autocomplete coexistence in the Jaws test on Chrome and FF by Phil. The other aspect is that "If we remove autocomplete=off the browser will no longer be instructed to not add it's own autocomplete dropdown/listbox", and the key is how to verify this through tests because many HTML 5 and Aria best practice Combobox examples don't have the autocomplete=off setting. If that interference does exist, those examples would have an issue.

Overall, it's odd to have both native and aria attributes with the same or opposite meaning. Especially for Combobox in which a user agent knows to search the data from the list box associated with an input, and no reason to use autocomplete.

@shunguoy shunguoy changed the title Fix the conflict case when aria-autocomplete and autocomplete are used together Conflict cases when aria-autocomplete and autocomplete are used together Sep 23, 2024
@shunguoy shunguoy added the T63 label Sep 30, 2024
@shunguoy
Copy link
Contributor Author

Triage: remove aria-autocomplete from the conflict list.

@shunguoy shunguoy self-assigned this Oct 1, 2024
@shunguoy shunguoy closed this as completed Oct 1, 2024
@MHoov MHoov added the Carbon Carbon related issue label Oct 7, 2024
@philljenkins
Copy link
Contributor

@shunguoy is this (removing autocomplete conflict check) being implemented in PR #2025 fix(engine): rule engine refactor and update ?
Changing file: accessibility-checker-engine/src/v2/aria/ARIADefinitions.ts
in branch dev-1974

@shunguoy
Copy link
Contributor Author

shunguoy commented Oct 7, 2024

@philljenkins yes. Will be deployed at the end of the release.

@philljenkins
Copy link
Contributor

An issue has also been opened against the W3C specs: #2337.

@philljenkins philljenkins linked a pull request Oct 7, 2024 that will close this issue
8 tasks
@philljenkins philljenkins mentioned this issue Nov 5, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Carbon Carbon related issue T63
Projects
None yet
Development

No branches or pull requests

3 participants