Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(engine): rule engine refactor and update #2025

Merged
merged 73 commits into from
Nov 6, 2024
Merged

fix(engine): rule engine refactor and update #2025

merged 73 commits into from
Nov 6, 2024

Conversation

shunguoy
Copy link
Contributor

@shunguoy shunguoy commented Sep 3, 2024 •
edited by philljenkins
Loading

  • New Rule(s): All rules

This PR is related to the following issue(s):

Testing reference:

I have conducted the following for this PR:

  • I validated this code in Chrome and FF
  • I validated this fix in my local env
  • I provided details for testing
  • This PR has been reviewed and is ready for test
  • I understand that the title of this PR will be used for the next release notes.

@shunguoy shunguoy changed the title fix(engine): Categorize the engine utility functions for maintenance fix(engine): rule engine refactor and update Sep 5, 2024
@shunguoy
refactor rules #1974
3b1c30a
@shunguoy
update the rules #1974
cc0c87f
@shunguoy
update the rule engine #1974
87faf20
@shunguoy
add denug for testing #1974
18db1dc
@shunguoy
add debug for testing #1974
4e27b7b
@shunguoy
clear up debug statement #1974
2d95642
@shunguoy
update rules for resolved role #1974
8c513c7
@shunguoy
update aria definition #1974
a74a077
@shunguoy
update ethe resolvedRole in rules #1974
521dfdb
@shunguoy
refactor the rule aria_accessiblename_exists #1974
9b56ace
@shunguoy
add console logs for debugging #1974
75ab2a6
@shunguoy
update the rules #1974
6bf3ebd
@shunguoy
refactor isNodeVisible function #1974
9d1c9a6
@shunguoy
refactor isNodeVisible #1974
7ecf41c
@shunguoy
update the role calculation #1974
570140b
@shunguoy
update the common util #1974
8b54e0f
@shunguoy
update the aria path which contains presentation #1974
0eb6a1d
@shunguoy
update accessible name calculation #1974
8f27418
@shunguoy
update the CommonUtil #1974
041afb7
@shunguoy
update svg and ariaautocomplete calculation #1974
75ef8e9
@shunguoy
update svg rule to use accNameUtil #1974
35d136b
@shunguoy
Update AccNameUtil #1974
65cd000
@shunguoy
update the rules for accessible name calculation #1974
60ba7a2
@shunguoy shunguoy mentioned this pull request Nov 1, 2024
Closed
@philljenkins philljenkins mentioned this pull request Nov 4, 2024
Closed
@philljenkins philljenkins mentioned this pull request Nov 4, 2024
Open
1 task
tombrunet
tombrunet previously approved these changes Nov 6, 2024
View reviewed changes
@tombrunet tombrunet merged commit 53aba40 into master Nov 6, 2024
17 checks passed
@tombrunet tombrunet deleted the dev-1974 branch November 6, 2024 21:17
This was linked to issues Nov 6, 2024
Fix(input_label_visible) should not trigger when clipped 0,0,0,0 - different behavior in FF vs Chrome #2085
Open
Rewrite accessible name module for the rule engine #2055
Closed
@shunguoy shunguoy linked an issue Nov 6, 2024 that may be closed by this pull request
Resolve element role when multiple values are provided #1973
Closed
This was unlinked from issues Nov 14, 2024
Resolve element role when multiple values are provided #1973
Closed
Conflict cases when aria-autocomplete and autocomplete are used together #2052
Closed
Rewrite accessible name module for the rule engine #2055
Closed
Fix(input_label_visible) should not trigger when clipped 0,0,0,0 - different behavior in FF vs Chrome #2085
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tombrunet tombrunet tombrunet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shunguoy @tombrunet