Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(engine): Update ARIA definition for the ARIA in HTML changes #1802

Merged
merged 8 commits into from
Jan 19, 2024

Conversation

shunguoy
Copy link
Contributor

@shunguoy shunguoy commented Jan 17, 2024

  • Rule bug: aria_role_redundant, aria_attribute_valid

This PR is related to the following issue(s):

#1518 #1535

Additional information can be found here:

Testing reference:

Test case 1 for #1518: test/v2/checker/accessibility/rules/aria_role_redundant_ruleunit/deletion_role.html
A new Recommendation message is shown after the fix: "The explicitly-assigned ARIA role "deletion" is redundant with the implicit role of the element s"

Test case 2 for #1535 test/v2/checker/accessibility/rules/aria_role_allowed_ruleunit/aside_role.html
The Violation should disappear after the fix: "The ARIA role 'doc-glossary' is not valid for the element aside" and a new Violation should appear: "The ARIA attributes "aria-expanded" are not valid for the element aside with ARIA role "doc-glossary".

I have conducted the following for this PR:

  • [x ] I validated this code in Chrome and FF
  • [ x] I validated this fix in my local env
  • [ x] I provided details for testing
  • This PR has been reviewed and is ready for test
  • [ x] I understand that the title of this PR will be used for the next release notes.

@shunguoy shunguoy changed the title fix(engine): Update ARIA definition for the ARIA in HTML update fix(engine): Update ARIA definition for the ARIA in HTML changes Jan 17, 2024
@shunguoy shunguoy marked this pull request as ready for review January 19, 2024 15:18
@ErickRenteria
Copy link
Contributor

Validated
Screenshot 2024-01-19 at 11 24 01 AM
Screenshot 2024-01-19 at 11 27 05 AM

@ErickRenteria ErickRenteria added this pull request to the merge queue Jan 19, 2024
Merged via the queue into master with commit c95dd7b Jan 19, 2024
15 checks passed
@shunguoy shunguoy deleted the dev-1518 branch January 29, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants