Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nodejs): add a network timeout in page loading to fix hanging issue #1945

Closed
wants to merge 3 commits into from

Conversation

shunguoy
Copy link
Contributor

@shunguoy shunguoy commented Jul 16, 2024

  • Automated tool bug

This PR is related to the following issue(s):

Testing reference:

  • see the HTML test case in [BUG]: Timeout on pages with a lazy loaded iframe #1892
    Test instruction: first build and install the checker, then run the following command from the command line:
    % npx achecker --outputFolder ~—/Downloads
    With the fix, an accessibility result should be outputted, otherwise, an error message "Navigation timeout of 30000 ms exceeded".

I have conducted the following for this PR:

  • I validated this code in Chrome and FF
  • I validated this fix in my local env
  • I provided details for testing
  • This PR has been reviewed and is ready for test
  • I understand that the title of this PR will be used for the next release notes.

@shunguoy shunguoy changed the title fix(node|karma|selenium): add a timeout in puppeteer page loading to fix page load hanging issue fix(node|karma|selenium): add a timeout in puppeteer page loading to fix hanging issue Jul 16, 2024
@shunguoy shunguoy changed the title fix(node|karma|selenium): add a timeout in puppeteer page loading to fix hanging issue fix(node|karma|selenium): add a network timeout in puppeteer page loading to fix hanging issue Jul 16, 2024
@shunguoy shunguoy changed the title fix(node|karma|selenium): add a network timeout in puppeteer page loading to fix hanging issue fix(node|karma|selenium): add a network timeout in page loading to fix hanging issue Jul 16, 2024
@shunguoy shunguoy changed the title fix(node|karma|selenium): add a network timeout in page loading to fix hanging issue fix(node|karma): add a network timeout in page loading to fix hanging issue Jul 16, 2024
@shunguoy shunguoy changed the title fix(node|karma): add a network timeout in page loading to fix hanging issue fix(node): add a network timeout in page loading to fix hanging issue Jul 16, 2024
@shunguoy shunguoy changed the title fix(node): add a network timeout in page loading to fix hanging issue fix(nodejs): add a network timeout in page loading to fix hanging issue Jul 16, 2024
@shunguoy shunguoy closed this Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant