Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(node): Add comments explaining value of the jest boilerplate #1950

Merged
merged 4 commits into from
Aug 6, 2024

Conversation

a-roberts
Copy link
Collaborator

calls out the use of baselines too

Contributes to: /issues/1949

  • Other (Provide information)

I was initially confused by the Jest boilerplate's intent - spoke with Tom and I think this explains it well and helped me to understand it so I can show our teams how to make use of it and the accessibility checker

This PR is related to the following issue(s):

Fixes #1949

Testing reference:

I've checked this looks fine in VSCode's markdown editor as well as running the tests with the expected behaviour

I have conducted the following for this PR:

  • I validated this code in Chrome and FF
  • I validated this fix in my local env
  • I provided details for testing
  • This PR has been reviewed and is ready for test
  • I understand that the title of this PR will be used for the next release notes.

calls out the use of baselines too

Contributes to: /issues/1949

Signed-off-by: Adam Roberts <[email protected]>
@tombrunet tombrunet changed the title docs: add comments explaining value of the jest boilerplate fix(node): Add comments explaining value of the jest boilerplate Aug 2, 2024
@ErickRenteria ErickRenteria merged commit 970d6b5 into master Aug 6, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: Basic Jest example doesn't work - fails test, doesn't pick up any set HTML passed in
4 participants