Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixrules(meta_redirect_optional, aria_parent_required, aria_child_valid): Map to WCAG and ACT rules to improve consistency #1962

Merged
merged 6 commits into from
Aug 1, 2024

Conversation

philljenkins
Copy link
Contributor

@philljenkins philljenkins commented Jul 26, 2024

Rules impacted:

  • aria_child_valid maps correctly to ACT bc4a75
  • aria_parent_required maps correctly to ACT ff89c9
  • meta_redirect_optional maps correctly to ACT bc659a

This PR is related to the following issue(s):

Testing reference:

  1. Confirm results in Action built file for the latest ACT Text Results - example are correct:
    • confirm that ACT bc659a2 is reported correctly.
    • confirm that ACT ff89c9 is reported correctly.
    • confirm that ACT bc4a75 is reported correctly.
  2. Confirm results in Action built file for the latest Rule listing are correct:
    • confirm that rule aria_child_valid is reported correctly under .
    • confirm that rule aria_parent_required is reported correctly under
    • confirm that rule meta_redirect_optional is reported correctly under .
  3. Confirm Help file changes are formatted correctly:
    • aria_child_valid.html lists 1.3.1 (See screenshots in issue)
    • aria_parent_required.html lists 1.3.1 (See screenshot in issue)

Supporting notes and details

I have conducted the following for this PR:

  • I validated this code in Chrome and FF
  • I validated this fix in my local env
  • I provided details for testing
  • This PR has been reviewed and is ready for test
  • I understand that the title of this PR will be used for the next release notes.

@philljenkins philljenkins linked an issue Jul 26, 2024 that may be closed by this pull request
4 tasks
@philljenkins philljenkins changed the title fixrules(meta_redirect_optional, aria_parent_required, aria_child_valid): Map to WCAG and ACT rules to improve consistencyM fixrules(meta_redirect_optional, aria_parent_required, aria_child_valid): Map to WCAG and ACT rules to improve consistency Jul 26, 2024
@philljenkins philljenkins marked this pull request as draft July 26, 2024 15:09
@philljenkins philljenkins marked this pull request as ready for review July 26, 2024 18:36
@ErickRenteria
Copy link
Contributor

ErickRenteria commented Jul 30, 2024

@philljenkins should the files be the same?
Screenshot 2024-07-30 at 2 44 16 PM

@philljenkins
Copy link
Contributor Author

philljenkins commented Jul 31, 2024

@ErickRenteria No, not exactly. The diff on the time it takes for an individual rule to run is not relevant, often affected by network and servers, so it's OK that one is zero on the other is one. So the two files don't have to match exactly.one.

@ErickRenteria ErickRenteria merged commit 34225eb into master Aug 1, 2024
15 checks passed
@tombrunet tombrunet deleted the phill-ACT-mapping branch August 2, 2024 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants