Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixrules(ARIA landmark regions): Consistent ARIA landmark messages and help #1978

Merged
merged 11 commits into from
Aug 15, 2024

Conversation

philljenkins
Copy link
Contributor

@philljenkins philljenkins commented Aug 9, 2024

Improve consistency of group and failure messages for the following ARIA "landmark region" related rules and help:

  1. aria_application_label_unique + help*
  2. aria_application_labelled + help*
  3. aria_article_label_unique + help*
  4. aria_banner_label_unique + help*
  5. aria_banner_single + help*
  6. aria_complementary_label_unique + help*
  7. aria_complementary_label_visible + help*
  8. aria_complementary_labelled
  9. aria_content_in_landmark
  10. aria_contentinfo_label_unique + help*
  11. aria_contentinfo_misuse
  12. aria_contentinfo_single
  13. aria_document_label_unique + help*
  14. aria_form_label_unique + help*
  15. aria_landmark_name_unique + help*
  16. aria_main_label_unique + help*
  17. aria_main_label_visible + help*
  18. aria_navigation_label_unique + help*
  19. aria_parent_required
  20. aria_region_label_unique + help*
  21. aria_region_labelled + help*
  22. aria_search_label_unique + help*
  23. aria_toolbar_label_unique + help*

*updated help too

This PR is related to the following issue(s):

Testing reference:

  1. Open the latest Rule Listing file built in Actions, for example see Rule listing
  2. Review the changes for the 23 rules listed above for text consistency, spelling, and changes as listed in ARIA consistent messages.xlsx
  • Screenshots below come from the Rule listing artifact built in Actions
  • Be sure to select the latest rules via the 7.3 ruleset to see all the latest rules:

Screenshot 2024-08-14 at 8 29 12 AM

  • Most of the changes map to 2.4.1, so you'll find the most changes there
  • check for consistency in messages, such as
    • Each element with ___ role ...
    • ... label that describes its purpose
    • Multiple elements with ___ role ...
      Screenshot 2024-08-14 at 8 41 13 AM

I have conducted the following for this PR:

  • I validated this code in Chrome and FF
  • I validated this fix in my local env
  • I provided details for testing
  • This PR has been reviewed and is ready for test
  • I understand that the title of this PR will be used for the next release notes.

@philljenkins
Copy link
Contributor Author

Updating messages in expected results files so automated build passes

@philljenkins
Copy link
Contributor Author

@ErickRenteria this is the PR we discussed in the Standup/retro. Shunguo had review the text changes in the box/note and excel spreadsheet, so this PR is ready for review & approval and QA

@ErickRenteria ErickRenteria merged commit 280d996 into master Aug 15, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ARIA landmark rule's messages consistency
3 participants