Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(extension): Fix large page timeouts - do not send 'pass' information outside of the page context #2005

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

tombrunet
Copy link
Member

@tombrunet tombrunet commented Aug 20, 2024

  • Other (Provide information)

This PR is related to the following issue(s):

Testing reference:

I have conducted the following for this PR:

  • I validated this code in Chrome and FF
  • I validated this fix in my local env
  • I provided details for testing
  • This PR has been reviewed and is ready for test
  • I understand that the title of this PR will be used for the next release notes.

@tombrunet tombrunet changed the title fix(engine): Fix large page timeouts - do not send 'pass' information outside of the page context fix(extension): Fix large page timeouts - do not send 'pass' information outside of the page context Aug 20, 2024
@tombrunet tombrunet requested a review from drjoho August 21, 2024 18:11
@tombrunet tombrunet marked this pull request as ready for review August 21, 2024 18:11
Copy link
Contributor

@drjoho drjoho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it process report before returning then fix up the pieces to use the processed report.

@ErickRenteria ErickRenteria merged commit e0ec192 into master Aug 27, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: Scan timeout on large page - extensions
3 participants