Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(engine): Update IBM_Accessibility policy to include new WCAG 2.2 rules #2061

Merged
merged 9 commits into from
Oct 1, 2024

Conversation

tombrunet
Copy link
Member

@tombrunet tombrunet commented Sep 30, 2024

  • Other (Provide information)
    draggable_alternative_exists, element_tabbable_unobscured, and target_spacing_sufficient have been in a preview mode as the IBM_Accessibility_next policy for several months. As the IBM Accessibility 7.3 requirements go into effect on Oct 1, this adds those rules to the main policy.

This PR is related to the following issue(s):

Testing reference:

  • Select Preview Rules - V7.3 should be auto-selected

I have conducted the following for this PR:

  • I validated this code in Chrome and FF
  • I validated this fix in my local env
  • I provided details for testing
  • This PR has been reviewed and is ready for test
  • I understand that the title of this PR will be used for the next release notes.

@philljenkins
Copy link
Contributor

philljenkins commented Sep 30, 2024

@tombrunet running the Action:Artifact for Chrome, I do not see the new default changes to IBM 7.3.

Looks like only the 3 rules were moved to "IBM Accessibility", shouldn't the settings also be changed?

Screenshot 2024-09-30 at 1 26 49 PM

@philljenkins
Copy link
Contributor

@tombrunet

  • it still has the 7.2 as the default option in the settings
    • when I select 'Preview Rules', it changes the guidelines to 7.3 (I think that is correct)
    • when I select 'Latest rules', it incorrectly changes it back to 7.2
    • when I select 'Reset defaults'. it incorrectly sets to 7.2
  • updated the text in the More Info pop-up, User Guide, and Quick guide too, so I changed these 3 files:
    • OptionsApp.tsx
    • QuickGuideACApp.tsx
    • UsingACApp.tsx

Screenshot 2024-09-30 at 4 49 04 PM

philljenkins
philljenkins previously approved these changes Oct 1, 2024
Copy link
Contributor

@philljenkins philljenkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, understand that the 7.3 will not be default until a Rules archive is built.
So this is validated with "Preview rules", which auto-sets the Guideline to IBM 7.3 - see screenshot
image

@philljenkins
Copy link
Contributor

philljenkins commented Oct 1, 2024

@tombrunet
Should the option/label IBM Accessibility 7.3 preview be changed to simply drop the "7.3" and be IBM Accessibility Preview? Yes, changed to IBM Accessibility next
Or does that also change with the deployment/build of the rules archive? No, not exactly. When Rule set archive is deployed, the `Latest new default will be

Screenshot 2024-10-01 at 11 41 03 AM

drjoho
drjoho previously requested changes Oct 1, 2024
Copy link
Contributor

@drjoho drjoho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the video: https://ibm.ent.box.com/file/1661566447030
Note that 7.3 is still not showing up as the default. Also, note that when I can get it on 7.3 through preview or one of the earlier rulesets like Aug 29 it still shows 7.2 as currently active.

Copy link
Contributor

@philljenkins philljenkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

validated that 7.3 is default for Preview rules set, and IBM Accessibility next if future option.
Screenshot 2024-10-01 at 1 39 43 PM

@philljenkins
Copy link
Contributor

philljenkins commented Oct 1, 2024

See the video: https://ibm.ent.box.com/file/1661566447030 Note that 7.3 is still not showing up as the default. Also, note that when I can get it on 7.3 through preview or one of the earlier rulesets like Aug 29 it still shows 7.2 as currently active.

That is the desired & correct behavior until a ruleset is archived & deployed such that a new Deployment date is displayed and the v7.3 will be selected. Otherwise it will break previous deployments. So a new video will be needed AFTER deployment showing the "new date"and "new default 7.3", until then the Preview rules shows that v7.3 is auto-selected for testing this PR.

@drjoho you'll need to change your "Requested change" to "Approve PR".

@tombrunet
Copy link
Member Author

See the video: https://ibm.ent.box.com/file/1661566447030 Note that 7.3 is still not showing up as the default. Also, note that when I can get it on 7.3 through preview or one of the earlier rulesets like Aug 29 it still shows 7.2 as currently active.

You never saved your settings. The active setting doesn't change until you save.

@ErickRenteria ErickRenteria dismissed drjoho’s stale review October 1, 2024 23:08

N/A due to server update

@ErickRenteria ErickRenteria merged commit 5bb8242 into master Oct 1, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add new WCAG 2.2 rules to the default policy starting Oct 1.
4 participants