Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds hiding of columns, replacing missing values, grand summaries, nano plots and group summaries features #9320

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Patowhiz
Copy link
Contributor

@rdstern this is ready for your review.
This PR adds the following in relation to gt R package:

  1. Hiding of columns.
  2. Nano plots.
  3. Replacing missing values.
  4. Group summaries.
  5. Grand summaries.

It doesn't exhaust the functionalities of the above gt features but attempts to simplify how to use them.

@rdstern
Copy link
Collaborator

rdstern commented Dec 19, 2024

@Patowhiz the first thing I wanted to check was the hiding of the columns. It is excellent that the sub-dialog is now available from many dialogs. But, in the hiding it is showing the original data file, (which is irrelevant), and not the summary file, which has the column I need to hide.

image

Looking at more now.

@rdstern
Copy link
Collaborator

rdstern commented Dec 19, 2024

Looking at more now.

I next tried to replace missing and (of course) got an error - which is the same problem I presume.

image

@rdstern
Copy link
Collaborator

rdstern commented Dec 22, 2024

@Patowhiz it is now 3 days since the problem I found, described above. I would have a much better Christmas if you could fix this soon, or at least reply and convince me it is easy to fix. Currently I have the fear that you might return again to only having gt for a presentation data frame, omitting the main use, which is a presentation (summary) table! That complicated the work for many months and I assumed was resolved by the discussions when you visited England in October.

I still live in hope.

@Patowhiz
Copy link
Contributor Author

@rdstern Thank you for testing this.

As I previously explained to you and the team in the UK, the tables sub-dialog is designed to work with data already in the data book. It uses our custom controls, which only operate on existing data within the data book.

The summary dialogs create an intermediary data frame (which David refers to as a table) that is then used to produce a gt table. The future plan was to extend or create controls that can interpret the R code generated by the main dialog to allow formatting of a data frame that has not yet been produced.

This is why you are correctly encountering the error column does not exist - the intermediary data frame doesn’t include that column. @ChrisMarsh82 is also aware of this limitation. This PR does not aim to create controls that interpret R code to determine the intermediary data frame produced by the main dialogs. Instead, it continues to assume that you are working with columns from the currently selected data frame.

You can test the gt features in this PR using dialogs that work with an existing data frame, such as the presentation or view data frame dialogs.

However, I do acknowledge that sub-dialog options not requiring modifications to the intermediary data frame, such as the themes feature, should work as expected.

Thanks again!

@rdstern
Copy link
Collaborator

rdstern commented Dec 23, 2024

@Patowhiz David has come to Reading since I wrote the entry below and he confirms your point of view, i.e. that linking your sub-dialog fully to summaries requires more work and that needs more R skills and concepts than can be expected from you. I hope it can be given high priority, perhaps mainly by @volloholic and @lilyclements amnd perhaps Abib, early next year.

@Patowhiz that's very disappointing. We had the team working on the one-variable summarise, two variables summarise and the main Tables > Summaries dialogs since your visit in October. And you, and @ChrisMarsh82 knew all along that the main parts of your sub-dialog would not work for any of those dialogs. I was really hoping that by mid-December our tables nightmare would be over. Is the main nightmare just beginning? Was @volloholic aware of this, following the October discussions?

You seem to be saying that there is quite complicated and important steps that still remain to be done, and that they are outside what you consider to have been your terms of reference? Should I have known this? How do you plan for your sub-dialog to work with the summaries? Do you plan to be involved, at least to supervise, or to delegate? If delegating, then to whom, and when?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants