Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-complete improvements, support "Any" attribute #30

Open
will-moore opened this issue Mar 22, 2023 · 1 comment
Open

Auto-complete improvements, support "Any" attribute #30

will-moore opened this issue Mar 22, 2023 · 1 comment

Comments

@will-moore
Copy link
Member

will-moore commented Mar 22, 2023

This aims to address 2 issues:

auto-complete is filtered by Attribute field

If you start with "Any" attribute (default) and enter search into the Value field, the auto-complete gives a list with many different Attributes:

Screenshot 2023-03-22 at 12 21 46

If you pick one e.g. Antibody contains pax6, then decide you wanted to pick a different one, you re-enter pax6 into the search field, but now you only see this (even though you never chose to filter these, since the Attribute field got changed when you picked the item above, and now it's filtering by that):

Screenshot 2023-03-22 at 12 23 37

we can now search by Any key

See ome/omero_search_engine#83

Previously you could only auto-complete with 'Any' key, but we needed to pick a specific Key to actually search.

Currently, there's no way to pick "pax6 with ANY key" from this list:

Screenshot 2023-03-22 at 14 11 14

Proposed changes:

  • Auto-complete should group by value, e.g. all "pax6" options above are merged into a single "pax6" item with "Any" key
  • First (default) option is just to search with the current text and "Any" key.
  • So, picking an Auto-complete item doesn't change the Attribute.
  • Therefore a user will only change the Attribute themselves. So we can use this to sort auto-complete responses, instead of filtering them.
  • If we pick value pax6 (Gene Symbol, Antibody, Original Gene Target...), then maybe when we go to choose Attribute, it lists the "pax6" Attributes first, before others:
contain pax6
--------------------------
Gene Symbol
Antibody
HGNC Gene Symbol
Nearest Human Holologue
Original Gene Target
Gene Symbol Synonyms
--------------------------
Study Attributes
--------------------------
Imaging Method
...
  • If you choose an Attribute: e.g. "Antibody" then auto-complete of Value gives you something that is NOT included in that Attribute (E.g. "Hela") then either we DO change the attribute when you pick auto-complete, or simply show "No results" which may be less confusing - otherwise you might think you got some results for Antibody: HeLa
@will-moore
Copy link
Member Author

If we group all auto-complete results by Value, then when we have entered "pax" we will see something like:

pax (9 images, Gene Symbol)
pax6 (2345 images, Gene Symbol, Antibody, HGNC G...)
pax7 (1234 images, Gene Symbol, Antibody, HGNC G...)
pax3 (1234 images, Gene Symbol, Antibody, HGNC G...)
...

Picking any of these would search by e.g. Key: any, Value: pax6

If the value isn't found in multiple Keys, then the auto-complete results would appear much as they do now.

NB: if any value matches Screens and Experiments, they will be grouped as they are now.
If any value matches Images and Screens/Experiments, they will need to appear as separate items...

Although the "Attribute" chooser is not updated when we choose an auto-complete, we still need to know whether to search by Container or Images.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant