Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extras: timestamp for journal entries #123

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

eqvinox
Copy link
Contributor

@eqvinox eqvinox commented Sep 1, 2022

... to allow nanosecond resolution.


Not much to say here, just useful to have a way of encoding nanosecond precision timestamps.

@mcr mcr self-assigned this Sep 1, 2022
Copy link
Collaborator

@mcr mcr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to include the changes for #122, so could you make them independant PRs?

Can't currently put options on captured log messages...
(Also adding a nanosecond timestamp in the next commit.)
... to allow nanosecond resolution.
@eqvinox
Copy link
Contributor Author

eqvinox commented Jul 23, 2023

This seems to include the changes for #122, so could you make them independant PRs?

I can't, this one depends on the options block added in #122, as it is adding an option for use inside of that block…

The commits shared between #122 and #123 are the exact same commits (same hash), merging #122 will make the first 2 commits disappear from this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants