PATCH: Always remove tmp orthoimages in color.color #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gliegard
approved these changes
Sep 12, 2023
gliegard
force-pushed
the
PATCH-always-remove-tmp-orthoimages
branch
from
2cdcb93 to
40d1bf3
Compare
|
Je ferme cette MR car c'est pour merger dans master, il faut faire un MR pour merger dans dev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The NamedTemporaryFile was created and direcly forgotten since only its name was assigned to a variable.
As a result, the resulting file was never properly deleted after coloration. This would clog memory of always-running servers (no reboot = no regular deletion of the /tmp/ folder).
By assigning the file and not its name to a variable, the deletion or conservation of the file can be control by removing or keeping the variable in the python context.