Fix edgecase with 1 input value that is not selected in subsample_data #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gliegard
requested changes
Mar 12, 2024
| np.array([20, 21, 22, 23, 24]), | ||
| torch.IntTensor([0, 1, 4]), | ||
| ), | ||
| # Edge cases |
There was a problem hiding this comment.
can you be more specific one each cases ?
ex: "one value case" ..
There was a problem hiding this comment.
Minor changes in formulations (comment and changelog), but code looks good!
For reference here is a related issue explaining the cause of this edge case: #83 (comment)
| ], | ||
| ) | ||
| def test_subsample_data(x, idx, choice): | ||
| # points w. |
There was a problem hiding this comment.
If this is a dead comment, can it be removed?
CHANGELOG.md
Outdated
There was a problem hiding this comment.
Could you be a bit more explicit here, and specify that this fix is related to subsampling?
leavauchier
force-pushed
the
fix-subsample
branch
from
ef43f34 to
36236f4
Compare
gliegard
previously approved these changes
Mar 13, 2024
leavauchier
force-pushed
the
fix-subsample
branch
from
36236f4 to
31c7cb7
Compare
leavauchier
force-pushed
the
fix-subsample
branch
from
31c7cb7 to
0be5fa2
Compare
CharlesGaydon
approved these changes
Mar 13, 2024
|
Low quality schematics for posterity 😬😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the preprocessing steps when subsampling data, there was a buggy edge case when there was only one point in the batch that had to be removed.
Up to now, the point was not removed (side effect of trying to force the output to be a Tensor when only one value was kept)
@MichelDaab or @gliegard can you have a look as @CharlesGaydon is not available?
Thanks