Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recipe #229: Behavior with Ranges #304

Open
wants to merge 32 commits into
base: master
Choose a base branch
from
Open

Conversation

kirschbombe
Copy link
Contributor

No description provided.

@kirschbombe kirschbombe self-assigned this Mar 9, 2022
@kirschbombe kirschbombe changed the title Behavior with Ranges (229) Recipe #229: Behavior with Ranges Mar 9, 2022
@glenrobson glenrobson linked an issue Sep 6, 2024 that may be closed by this pull request
@triplingual triplingual self-assigned this Sep 27, 2024
@triplingual
Copy link
Contributor

Also, ach, sorry @glenrobson about making the dimensions strings instead of ints. 🤦🏻‍♂️

@triplingual
Copy link
Contributor

  • Remove restrictions section as there are none

Noting that in the Cookbook authors' call we saw that the Cookbook is inconsistent on this matter. Mine have kept it in, so I left it in this one as well. An issue for the Cookbook editors to resolve whether removing it or leaving it is cognitively less of a load for the range of audiences the Cookbook is trying to reach.

@triplingual
Copy link
Contributor

  • Standardise the order of height and width within the manifest.

Done in 18c9f8a

@triplingual
Copy link
Contributor

  • In the use case: could you mention the noNav use case and with the thumbnail behaviour focus on end users e.g. something like "As a user using a video I would like to have access to thumbnail scrubbing to quickly navigate a video".

Though this is the conventional phrasing for software use cases, the Cookbook by and large uses a phrasing of "you want to [XYZ]" in the Use Case section, so I've rewritten the use case per @markpbaggett's ideas (with additional editing) but left it in the Cookbook's usual phrasing.

At first it didn't make sense to take out the 'Alternate' part because it is not supposed to render as a standard TOC. But I came around to agreeing because thumbnail navigation is inherently alternate
@triplingual
Copy link
Contributor

  • We discussed leaving the label in the structure and rename it to “Thumbnail Navigation”

Done in 2e84fc3

@triplingual
Copy link
Contributor

  • We suggest maybe the title could be "Adding Thumbnail Navigation and noNav to a Video Resource" as the recipe shows noNav and thumbnail behaviours.

Done in e753530

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta: ready-for-trc Issue is ready for TRC review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

behavior property with Ranges
4 participants