-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
0135 annotating point in canvas #413
Conversation
…n-canvas Draft recipe 0135 annotating point
@@ -0,0 +1,90 @@ | |||
{ | |||
"@context": ["http://iiif.io/api/presentation/3/context.json", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is causing the build error. It shouldn't have a , at the end.
I think this will be the new context for the point selector: https://iiif.io/api/registry/selectors/context.json Once the following has been merged: https://github.com/IIIF/api/pull/2231/files |
Also, we will likely add the Selectors context to the Presi context, so there should be no need to import in a Manifest. |
The cookbook editors are happy for this to go to the TRC but request the following changes:
"You want to annotate a coordinate of the image rather than a region. You have a map with some locations that can be represented better by a single coordinate. You want to add some auxiliary data relative to a specific point of the image (e.g. some spectroscopic analysis made on a manuscript)." This is to be consistent with other use cases in other recipes. |
{% include manifest_links.html viewers="" manifest="manifest.json" %} | ||
|
||
{% include jsonviewer.html src="manifest.json" config='data-line="75-83"' %} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure what is going on but it looks like this commit wasn't applied for some reason: giacomomarchioro@2287c46
@glenrobson I wasn't able to make a new commit, I have tried to a pull request directly from my branch to master. Not sure it is okay, in case could you please explain me the other procedure to force the update? |
…n-canvas Cookbook editors review
Looks like the changes have stuck now. |
No description provided.