fixes install dependencies workflow and lint errors #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vikhyath08
approved these changes
Jan 14, 2022
krashish8
reviewed
Feb 8, 2022
| @@ -49,7 +49,7 @@ def validate(self, attrs): | |||
| raise serializers.ValidationError( | |||
| "Please login using @itbhu.ac.in student email id only") | |||
| name = jwt['name'] | |||
| user = User() | |||
| user = get_user_model() | |||
There was a problem hiding this comment.
@nb9960 Should this be user = get_user_model()() instead? I think this method returns a user model and not the user object.
Something like this should work imo:
UserModel = get_user_model()
user = UserModel() # or user = UserModel.objects.create_user(...)
...
user.save()cc: @Vikhyath08
IIT-BHU-InstiApp/IIT-BHU-app#339: Seems like this is a general issue, not related to branch changers.
I fixed a similar bug last time by just reverting the change 😛 (#76), but directly using User might not be good if someone is using custom user model.
There was a problem hiding this comment.
Thanks for pointing out the issue, Recent Commit should probably fix this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.