Merging main to llvm12 #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A docker image is made in necessary129/manylinux2014-LLVM with prebuilt LLVM + cmake + ninja cibuildwheel is being used to generate the wheels. Which uses `auditwheel` to bundle linked libraries. So the ELF patching in `preparation.py` is not needed. The includes can be be found by Python by itself. Only `utils.h` needs to be specifically included.
A new musl docker image was made. Which would make it possible to build musl wheels also.
Will publish to pypi on release
Also removed the prebuild wheels as wheel as CI autogenerated now
Will also publish to testpypi first on release, and a manual workflow dispatch will have the option to deploy to actual pypi
Compare the python module output to the oracle
Will test each FA and SYM flevel embeddings also
Also fix a memory leak caused by not freeing the `__cxx::demangle` return pointer
Python wheels are built in GLIBc ~ 2.17 so some functions are not demangled properly. So we rebuild them using the ir2vec binary and test the Python output against it. The ir2vec binary output is tested against the actual oracle in another workflow. So, this should be fine.
clang doesn't compile on musllinux directly. Need to figure that out. in the meantime, don't build it. musl is not common anyway.
Add Python wheel building + Publishing workflow
Publishing to PyPI related changes
Incremental changes in README.md
nileshshah21
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.