-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring of buffer handling system #324
Conversation
…. The removal of the id has caused some unused parameter warnings. I also changed the structure of the BufferHandler a little bit to allow for a decorator pattern for the logger
…xed some bugs in the pointtopoint mpi wrappers for blocking communication
…nd with particles
…ation of bufferhandler
@@ -0,0 +1,117 @@ | |||
#include "Ippl.h" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in genera i.e. for all test a high level description of what is tested would be nice for ALL tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good in general. Thanks. I have a few comments though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Enhanced Buffer Management with Logging
Summary
This pull request introduces a
BufferHandler
class along with aLoggingBufferHandler
decorator to simplify the buffer management and add logging functionality. As well as added code to theCommunicator
to gather all logs and store them in a file.Changes
1. BufferHandler Implementation
BufferHandler
class for buffer management, without the need for thetag
attribute.2. LoggingBufferHandler Decorator
LoggingBufferHandler
decorator, which wrapsBufferHandler
and logs buffer operations.3. Integration with Communicator Class
LoggingBufferHandler
into theCommunicator
class.4. Serialization and Deserialization
LogEntry
data to support easy handling of log data.6. Unit Tests
BufferHandler
andLoggingBufferHandler
and serialization, covering core functionalities, logging operations, and serialization/deserialization.Testing