Modify getDataset repository API call to use 'excludeFiles' parameter #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GPortas
added
pm.GREI-d-2.7.1
ekraffmiller
requested changes
Jan 3, 2024
There was a problem hiding this comment.
Please add a test to get the deaccessioned dataset when the user has logged out. That is the use case that we need to support in the SPA.
|
I just added a test for the scenario you mention, but it is failing due to the API issue I explain on |
|
Waiting for: IQSS/dataverse#10207 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Modifies getDataset repository API call to use 'excludeFiles' parameter.
Also adds more test cases for deaccessioned datasets and getDataset repository method.
Which issue(s) this PR closes:
Related Dataverse PRs:
Suggestions on how to test this: