Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds create dataset use case #114

Merged
merged 38 commits into from
Feb 12, 2024
Merged

Conversation

GPortas
Copy link
Contributor

@GPortas GPortas commented Jan 10, 2024

What this PR does / why we need it:

This PR includes the createDataset use case. This new use case allows to create a dataset in Dataverse, given a NewDataset model and the collection id where the new dataset will be created.

Before calling the repository creation operation, the use case performs validation of the metadata fields of the different metadata blocks of the new dataset.

This validation throws validation errors of different subtypes, depending on the nature of the error. The most notable aspect of this error handling design is that from the errors generated, we can know which particular field is invalid. Given this information, this mechanism will allow error messages to be dynamically rendered within a form, such as the dataset creation form in the SPA.

Which issue(s) this PR closes:

Related Dataverse PRs:

Special notes for your reviewer:

This is the first resource creation operation in the module after the restructuring.

Suggestions on how to test this:

Check integration tests on GitHub actions or in local runs.

@MellyGray MellyGray assigned GPortas and unassigned MellyGray Jan 22, 2024
@GPortas GPortas requested a review from MellyGray January 22, 2024 16:04
@GPortas GPortas assigned MellyGray and unassigned GPortas Jan 22, 2024
@MellyGray MellyGray assigned GPortas and unassigned MellyGray Jan 23, 2024
@GPortas GPortas requested a review from MellyGray January 23, 2024 15:57
@GPortas GPortas assigned MellyGray and unassigned GPortas Jan 23, 2024
Copy link
Contributor

@MellyGray MellyGray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for applying the suggested changes

@ekraffmiller
Copy link
Contributor

looks good, all tests passed

@ekraffmiller ekraffmiller merged commit 5b022c1 into develop Feb 12, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pm.GREI-d-2.7.1 NIH, yr2, aim7, task1: R&D UI modules for creating datasets and supporting publishing workflows pm.GREI-d-2.7.2 NIH, yr2, aim7, task2: Implement UI modules for creating datasets and publishing workflows Size: 10 A percentage of a sprint. 7 hours. SPA: Create Dataset Page
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create use case to create a dataset
3 participants