Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend get collection use case #215

Merged
merged 4 commits into from
Nov 22, 2024
Merged

Conversation

g-saracca
Copy link
Contributor

@g-saracca g-saracca commented Nov 11, 2024

What this PR does / why we need it:

Extends the GetCollection use case to return the next information also:

  • contacts
  • type
  • isMetadataBlockRoot
  • isFacetRoot

Which issue(s) this PR closes:

Suggestions on how to test this:

Visual code inspection and run tests (integration test was modified)

Is there a release notes update needed for this change?:

No

Additional documentation:

No

@g-saracca g-saracca added Waiting Size: 3 A percentage of a sprint. 2.1 hours. GREI Re-arch GREI re-architecture-related Original size: 3 SPA: Edit Collection Page SPA.Q4.3 Edit Collection Page FY25 Sprint 10 FY25 Sprint 10 (2024-11-06 - 2024-11-20) labels Nov 11, 2024
@g-saracca g-saracca added Waiting and removed Waiting labels Nov 12, 2024
@g-saracca g-saracca changed the title Feat/214 extend get collection Extend get collection use case Nov 15, 2024
@g-saracca g-saracca requested a review from ChengShi-1 November 19, 2024 15:30
Copy link
Contributor

@ChengShi-1 ChengShi-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems good, approve!

@cmbz cmbz added the FY25 Sprint 11 FY25 Sprint 11 (2024-11-20 - 2024-12-04) label Nov 21, 2024
@ofahimIQSS ofahimIQSS self-assigned this Nov 22, 2024
@ofahimIQSS
Copy link
Contributor

@g-saracca it looks like publish-gpr failed when I tried to rerun the github actions: https://github.com/IQSS/dataverse-client-javascript/actions/runs/11836322422/job/33390578876?pr=215

@g-saracca
Copy link
Contributor Author

Hi @ofahimIQSS, yep, we have an open issue for fixing that behavior, its when you re-run de deploy_pr/publish-gpr action without any new commit.
The alpha deploy when merging to develop is working correctly.

@ofahimIQSS
Copy link
Contributor

Merging PR

@ofahimIQSS ofahimIQSS merged commit d48324a into develop Nov 22, 2024
4 of 5 checks passed
@ofahimIQSS ofahimIQSS deleted the feat/214-extend-get-collection branch November 22, 2024 16:53
@ofahimIQSS ofahimIQSS removed their assignment Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FY25 Sprint 10 FY25 Sprint 10 (2024-11-06 - 2024-11-20) FY25 Sprint 11 FY25 Sprint 11 (2024-11-20 - 2024-12-04) GREI Re-arch GREI re-architecture-related Original size: 3 Size: 3 A percentage of a sprint. 2.1 hours. SPA: Edit Collection Page SPA.Q4.3 Edit Collection Page
Projects
Status: Done 🧹
Development

Successfully merging this pull request may close these issues.

Extend GetCollection use case
4 participants