-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OIDC Bearer Token Auth mechanism based on the PoC design #224
Open
g-saracca
wants to merge
8
commits into
develop
Choose a base branch
from
feat/206-oidc-bearer-token-mechanism
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
g-saracca
added
Size: 3
A percentage of a sprint. 2.1 hours.
GREI Re-arch
GREI re-architecture-related
Original size: 3
SPA.Q4.4
OIDC login + API authentication
FY25 Sprint 11
FY25 Sprint 11 (2024-11-20 - 2024-12-04)
labels
Nov 25, 2024
ekraffmiller
reviewed
Dec 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I just have a question about setting withCredentials
ekraffmiller
approved these changes
Dec 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
FY25 Sprint 11
FY25 Sprint 11 (2024-11-20 - 2024-12-04)
FY25 Sprint 12
FY25 Sprint 12 (2024-12-04 - 2024-12-18)
GREI Re-arch
GREI re-architecture-related
Original size: 3
Size: 3
A percentage of a sprint. 2.1 hours.
SPA.Q4.4
OIDC login + API authentication
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds OIDC Bearer Token Auth mechanism based on the PoC design.
Also adds a
RegisterUser
use case based on the new api endpoint added in IQSS/dataverse#10972Which issue(s) this PR closes:
Suggestions on how to test this:
This issue just adds a new mechanism to js-dataverse use cases, there is a unit test to check that the bearer token is being sent correctly in the Authorization header when configured with a bearer token.
Also a unit test for the RegisterUser use case has been added, more in-depth testing will be done on the SPA integration.