Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OIDC Bearer Token Auth mechanism based on the PoC design #224

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from

Conversation

g-saracca
Copy link
Contributor

@g-saracca g-saracca commented Nov 25, 2024

What this PR does / why we need it:

Adds OIDC Bearer Token Auth mechanism based on the PoC design.
Also adds a RegisterUser use case based on the new api endpoint added in IQSS/dataverse#10972

Which issue(s) this PR closes:

Suggestions on how to test this:

This issue just adds a new mechanism to js-dataverse use cases, there is a unit test to check that the bearer token is being sent correctly in the Authorization header when configured with a bearer token.
Also a unit test for the RegisterUser use case has been added, more in-depth testing will be done on the SPA integration.

@g-saracca g-saracca added Size: 3 A percentage of a sprint. 2.1 hours. GREI Re-arch GREI re-architecture-related Original size: 3 SPA.Q4.4 OIDC login + API authentication FY25 Sprint 11 FY25 Sprint 11 (2024-11-20 - 2024-12-04) labels Nov 25, 2024
@g-saracca g-saracca self-assigned this Nov 29, 2024
@g-saracca g-saracca removed their assignment Nov 29, 2024
@ekraffmiller ekraffmiller self-assigned this Dec 2, 2024
Copy link
Contributor

@ekraffmiller ekraffmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I just have a question about setting withCredentials

src/core/infra/repositories/apiConfigBuilders.ts Outdated Show resolved Hide resolved
@g-saracca g-saracca assigned g-saracca and unassigned g-saracca Dec 3, 2024
Copy link
Contributor

@ekraffmiller ekraffmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@cmbz cmbz added the FY25 Sprint 12 FY25 Sprint 12 (2024-12-04 - 2024-12-18) label Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FY25 Sprint 11 FY25 Sprint 11 (2024-11-20 - 2024-12-04) FY25 Sprint 12 FY25 Sprint 12 (2024-12-04 - 2024-12-18) GREI Re-arch GREI re-architecture-related Original size: 3 Size: 3 A percentage of a sprint. 2.1 hours. SPA.Q4.4 OIDC login + API authentication
Projects
Status: Ready for QA ⏩
Development

Successfully merging this pull request may close these issues.

Add OIDC Bearer Token Auth mechanism based on the PoC design
3 participants