Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update GetDatasetFiles and GetDatasetFileCounts use cases with the latest API changes #91

Merged
merged 5 commits into from
Oct 2, 2023
Merged

Update GetDatasetFiles and GetDatasetFileCounts use cases with the latest API changes #91

merged 5 commits into from
Oct 2, 2023

Conversation

GPortas
Copy link
Contributor

@GPortas GPortas commented Sep 25, 2023

What this PR does / why we need it:

This PR includes the following changes:

  • New properties added to the File model: friendlyType, deleted, tabularData and fileAccessRequest.
  • GetDatasetFiles and GetDatasetFileCounts now accept the optional parameter "includeDeaccessioned" which, if enabled, causes the API to consider deaccessioned versions when searching for the dataset version to obtain files or file counts.

Which issue(s) this PR closes:

Related Dataverse PRs:

Suggestions on how to test this:

  • Visual inspection of the code
  • Check unit and integration tests execution in GitHub actions

Is there a release notes update needed for this change?:

  • New properties added to the File model: friendlyType, deleted, tabularData and fileAccessRequest.
  • Deaccessioned dataset support in GetDatasetFiles and GetDatasetFileCounts use cases.

Additional documentation:

None

@GPortas GPortas marked this pull request as ready for review September 25, 2023 18:33
@GPortas GPortas added the Size: 3 A percentage of a sprint. 2.1 hours. label Sep 27, 2023
@sekmiller sekmiller assigned sekmiller and unassigned sekmiller Sep 29, 2023
@MellyGray MellyGray self-assigned this Oct 2, 2023
MellyGray
MellyGray approved these changes Oct 2, 2023
View reviewed changes
Copy link
Contributor

@MellyGray MellyGray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Approved 🎉

@MellyGray MellyGray removed their assignment Oct 2, 2023
@kcondon kcondon self-assigned this Oct 2, 2023
@kcondon kcondon merged commit ec40348 into develop Oct 2, 2023
2 checks passed
@kcondon kcondon deleted the 85-files-use-cases-extension branch October 2, 2023 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MellyGray MellyGray MellyGray approved these changes

Assignees

@kcondon kcondon

Labels
Size: 3 A percentage of a sprint. 2.1 hours.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update file use cases with the latest API changes
4 participants
@GPortas @MellyGray @sekmiller @kcondon