feat: add type check to detect type errors

IQSS · Nov 2, 2023 · 462ac44 · 462ac44
1 parent 1b8fae7
commit 462ac44
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 2 deletions.
diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml
@@ -27,6 +27,9 @@ jobs:
         working-directory: packages/design-system
         run: npm run build
 
+      - name: Type check
+        run: tsc --noEmit
+
       - name: ESLint
         run: npm run lint:eslint
 

diff --git a/package.json b/package.json
@@ -62,9 +62,11 @@
     "storybook": "concurrently 'storybook dev -p 6006 && open \"http://localhost:6006\"' 'cd packages/design-system && npm run storybook'",
     "build-storybook": "storybook build",
     "test:storybook": "test-storybook",
-    "test:storybook-all": "concurrently 'test-storybook' 'cd packages/design-system && npm run test:storybook'"
+    "test:storybook-all": "concurrently 'test-storybook' 'cd packages/design-system && npm run test:storybook'",
+    "typecheck": "tsc --noEmit"
   },
   "pre-commit": [
+    "typecheck",
     "lint:fix",
     "git:add",
     "test:unit",

diff --git a/...ataset/dataset-files/files-table/file-actions/download-files/DownloadFilesButton.spec.tsx b/...ataset/dataset-files/files-table/file-actions/download-files/DownloadFilesButton.spec.tsx
@@ -113,7 +113,7 @@ describe('DownloadFilesButton', () => {
     const datasetWithDownloadFilesPermission = DatasetMother.create({
       permissions: DatasetPermissionsMother.createWithFilesDownloadAllowed()
     })
-    const files = FileMother.createMany(2)
+    const files = FileMother.createMany(2, { tabularData: undefined })
     cy.mountAuthenticated(
       withDataset(
         <DownloadFilesButton files={files} fileSelection={{}} />,