Skip to content

Commit

Permalink
re-added required attr to match spec after testing
Browse files Browse the repository at this point in the history
  • Loading branch information
Matt Mangan committed Jan 18, 2024
1 parent ebc2b36 commit bc14953
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
2 changes: 1 addition & 1 deletion src/sections/create-dataset/CreateDatasetForm.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ export const CreateDatasetFormPresenter: React.FC<FormPresenterProps> = ({
className={'create-dataset-form'}>
<Row>
<Col md={9}>
<Form.Group controlId="createDatasetTitle">
<Form.Group controlId="createDatasetTitle" required>
<Form.Group.Label>{t('datasetForm.title')}</Form.Group.Label>
<Form.Group.Input
readOnly={submissionStatus === SubmissionStatusEnums.IsSubmitting && true}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ describe('Form component', () => {
cy.findByLabelText(/Title/i)
.should('exist')
.type('Test Dataset Title')
.should('have.attr', 'required', 'required')
.and('have.value', 'Test Dataset Title')

cy.findByText(/Save Dataset/i).click()
Expand Down

0 comments on commit bc14953

Please sign in to comment.