Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Spike - Frontend] Refine UI styling of file tab action buttons #174

Closed
GPortas opened this issue Sep 8, 2023 · 0 comments · Fixed by #175
Closed

[Spike - Frontend] Refine UI styling of file tab action buttons #174

GPortas opened this issue Sep 8, 2023 · 0 comments · Fixed by #175
Assignees
@MellyGray
Labels
MVP Milestone 2 MVP Milestone 2: Add a Dataset pm.GREI-d-2.7.1 NIH, yr2, aim7, task1: R&D UI modules for creating datasets and supporting publishing workflows pm.GREI-d-2.7.2 NIH, yr2, aim7, task2: Implement UI modules for creating datasets and publishing workflows Size: 30 A percentage of a sprint. 21 hours. (formerly size:33) SPA: Dataset page (View)

Comments

@GPortas
Copy link
Contributor

GPortas commented Sep 8, 2023 •
edited by MellyGray
Loading

Overview of the Feature Request

After reviewing PR #162 a couple of styling issues have been detected.

column_limiter
    1. There is a line between columns that looks like introduced by default. This does not exist in JSF and can be confusing for the user.
    1. The button group of actions looks like two different buttons. The top and bottom lines of the button group should be straight as in the default react bootstrap component (https://react-bootstrap.netlify.app/docs/components/button-group)
    1. Vertically align in the middle the text and checkbox of the header, the action buttons and the checkbox of the table rows
      image
      image

What kind of user is the feature intended for?

All users

What inspired the request?

What existing behavior do you want changed?

Files table UI

Any brand new behavior do you want to add to Dataverse?

None

Any open or closed issues related to this feature request?
@GPortas GPortas added MVP Milestone 2 MVP Milestone 2: Add a Dataset pm.GREI-d-2.7.1 NIH, yr2, aim7, task1: R&D UI modules for creating datasets and supporting publishing workflows pm.GREI-d-2.7.2 NIH, yr2, aim7, task2: Implement UI modules for creating datasets and publishing workflows SPA: Dataset page (View) labels Sep 8, 2023
@GPortas GPortas moved this to Re-arch: SPA MVP (Guillermo) in IQSS Dataverse Project Sep 8, 2023
@GPortas GPortas mentioned this issue Sep 8, 2023
Merged
@GPortas GPortas added the Size: 30 A percentage of a sprint. 21 hours. (formerly size:33) label Sep 13, 2023
@GPortas GPortas moved this from Re-arch: SPA MVP (Guillermo) to SPRINT READY in IQSS Dataverse Project Sep 13, 2023
@MellyGray MellyGray self-assigned this Sep 19, 2023
@MellyGray MellyGray mentioned this issue Sep 20, 2023
Merged
@MellyGray MellyGray moved this from SPRINT READY to Clear of the Backlog in IQSS Dataverse Project Sep 20, 2023
@MellyGray MellyGray linked a pull request Sep 25, 2023 that will close this issue
174 - Refine UI styling Files Tab #175
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MellyGray MellyGray

Labels
MVP Milestone 2 MVP Milestone 2: Add a Dataset pm.GREI-d-2.7.1 NIH, yr2, aim7, task1: R&D UI modules for creating datasets and supporting publishing workflows pm.GREI-d-2.7.2 NIH, yr2, aim7, task2: Implement UI modules for creating datasets and publishing workflows Size: 30 A percentage of a sprint. 21 hours. (formerly size:33) SPA: Dataset page (View)
Projects
IQSS Dataverse Project
Status: No status
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

174 - Refine UI styling Files Tab IQSS/dataverse-frontend
2 participants
@GPortas @MellyGray