174 - Refine UI styling Files Tab #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MellyGray
changed the title
MellyGray
changed the title
Base automatically changed from
feature/168-integration-file-counts
to
feature/167-integration-dataset-page-filters
September 22, 2023 10:47
Base automatically changed from
feature/167-integration-dataset-page-filters
to
develop
September 22, 2023 19:38
…into feature/174-refine-ui-styling-file-tab
jayanthkomarraju
pushed a commit
to jayanthkomarraju/dataverse-frontend
that referenced
this pull request
May 31, 2024
…ile-tab 174 - Refine UI styling Files Tab
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR addresses the issue of CSS styling inconsistencies in the Files Tab. It ensures that the styles for the Files Tab are consistent with the JSF UI.
Which issue(s) this PR closes:
Special notes for your reviewer:
Some changes where requested in this other PR
Suggestions on how to test this:
To test the changes introduced by this PR, follow these steps:
Install the necessary dependencies using npm install.
Build the design system with cd packages/design-system && npm run build.
Navigate back to the root directory with cd ../../.
Start Storybook with npm run storybook.
Visit the Dataset Page in Storybook and inspect the Files Tab.
Ensure that the Files Tab elements are displayed consistently and that the styles have been improved according to the changes made in this PR. Compare the display to the previous state
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
No
Additional documentation: