Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the hard-coded part in getByPrivateUrlToken in DatasetJSDataverseRepo #536

Closed
ChengShi-1 opened this issue Oct 31, 2024 · 0 comments · Fixed by #544
Closed

Remove the hard-coded part in getByPrivateUrlToken in DatasetJSDataverseRepo #536

ChengShi-1 opened this issue Oct 31, 2024 · 0 comments · Fixed by #544
Labels
FY25 Sprint 9 FY25 Sprint 9 (2024-10-23 - 2024-11-06) GREI Re-arch GREI re-architecture-related Original size: 3 Size: 3 A percentage of a sprint. 2.1 hours. SPA.Q4.10 Resolve TODOs and tech debt SPA

Comments

@ChengShi-1
Copy link
Contributor

Overview of the Feature Request
From the DatasetJSDataverseRepository.ts, there are a hard-coded part, related to permissions, locks, and download sizes when handling datasets with a privateUrlToken. The related APIs are available in js-dataverse, so those Todos could be solved. We need to add getByPrivateUrlToken locks, permission and filesTotalDownloadSize for privateURL, connecting with js dataverse.
@ChengShi-1 ChengShi-1 added SPA SPA.Q4.10 Resolve TODOs and tech debt FY25 Sprint 9 FY25 Sprint 9 (2024-10-23 - 2024-11-06) labels Oct 31, 2024
@ChengShi-1 ChengShi-1 changed the title Feature Request/Idea: Remove the hard-coded part in getByPrivateUrlToken in DatasetJSDataverseRepo Remove the hard-coded part in getByPrivateUrlToken in DatasetJSDataverseRepo Oct 31, 2024
@ChengShi-1 ChengShi-1 self-assigned this Nov 1, 2024
@ChengShi-1 ChengShi-1 moved this to This Sprint 🏃‍♀️ 🏃 in IQSS Dataverse Project Nov 1, 2024
@ChengShi-1 ChengShi-1 moved this from This Sprint 🏃‍♀️ 🏃 to In Progress 💻 in IQSS Dataverse Project Nov 1, 2024
@ChengShi-1 ChengShi-1 added the GREI Re-arch GREI re-architecture-related label Nov 1, 2024
@ChengShi-1 ChengShi-1 mentioned this issue Nov 5, 2024
Merged
@ChengShi-1 ChengShi-1 linked a pull request Nov 5, 2024 that will close this issue
536 remove the hard coded part in getbyprivateurltoken in datasetjsdataverserepo #544
Merged
@ChengShi-1 ChengShi-1 added Size: 3 A percentage of a sprint. 2.1 hours. Original size: 3 labels Nov 5, 2024
@ChengShi-1 ChengShi-1 removed their assignment Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
FY25 Sprint 9 FY25 Sprint 9 (2024-10-23 - 2024-11-06) GREI Re-arch GREI re-architecture-related Original size: 3 Size: 3 A percentage of a sprint. 2.1 hours. SPA.Q4.10 Resolve TODOs and tech debt SPA
Projects
None yet
Milestone
No milestone
1 participant
@ChengShi-1