536 remove the hard coded part in getbyprivateurltoken in datasetjsdataverserepo #544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in-datasetjsdataverserepo' of https://github.com/IQSS/dataverse-frontend into 536-remove-the-hard-coded-part-in-getbyprivateurltoken-in-datasetjsdataverserepo
ChengShi-1
added
FY25 Sprint 9
g-saracca
reviewed
Nov 11, 2024
g-saracca
approved these changes
Nov 12, 2024
|
Merging PR- tests passed...one observation though, 2 tests were pending.
|
ofahimIQSS
deleted the
536-remove-the-hard-coded-part-in-getbyprivateurltoken-in-datasetjsdataverserepo
branch
Hi Omer, thanks for QA! They are pending because we didn't finish some functions there so we skipped them. #543 this one solved one of the pending test, but this branch didn't update to current version before your merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
It was a todo task waiting for the implementation of getbyprivateurltoken from js-dataverse side. Since the implementation is done, we are able to remove some hard-coded part with the results from api.
Which issue(s) this PR closes:
Special notes for your reviewer:
Suggestions on how to test this:
Run the e2e test for DatasetJSDataverseRepository
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
No
Is there a release notes update needed for this change?:
No
Additional documentation: